Updated client registration handler to behave more like the vscode #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, unknown handlers will throw. Also fixed bug where some handlers were export their registration options when they shouldn't be
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 71.60% 71.46% -0.14%
==========================================
Files 251 251
Lines 11908 11892 -16
Branches 813 806 -7
==========================================
- Hits 8527 8499 -28
- Misses 3381 3393 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated client registration handler to behave more like the vscode one, unknown handlers will throw.
Also fixed bug where some handlers were export their registration options when they shouldn't be. This was introduced with the latest refactor.