Skip to content

OnTypeRename -> LinkedEditingRange #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions debug-adapter-protocol.sha.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- This is the last commit we caught up with https://github.com/microsoft/debug-adapter-protocol/commits/gh-pages
lastSha: fd7d38013c9e13e92c0ca4dfa83048d355cb057d
lastSha: eded56aa372c7921205fad496e87f57d2adf176d

https://github.com/microsoft/debug-adapter-protocol/compare/fd7d38013c9e13e92c0ca4dfa83048d355cb057d..gh-pages
https://github.com/microsoft/debug-adapter-protocol/compare/eded56aa372c7921205fad496e87f57d2adf176d..gh-pages
4 changes: 2 additions & 2 deletions language-server-protocol.sha.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- This is the last commit we caught up with https://github.com/Microsoft/language-server-protocol/commits/gh-pages
lastSha: ed36538a180f15d33ffb03365fba4ace47b42d68
lastSha: c485961250d0eb41e53b148b55262ec180b63273

https://github.com/Microsoft/language-server-protocol/compare/ed36538a180f15d33ffb03365fba4ace47b42d68..gh-pages
https://github.com/Microsoft/language-server-protocol/compare/c485961250d0eb41e53b148b55262ec180b63273..gh-pages
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ public class TextDocumentClientCapabilities : CapabilitiesBase
public Supports<SelectionRangeCapability?> SelectionRange { get; set; }

/// <summary>
/// Capabilities specific to the `textDocument/onTypeRename` request.
/// Capabilities specific to the `textDocument/linkedEditingRange` request.
///
/// Since 3.16.0
/// </summary>
public Supports<OnTypeRenameClientCapabilities?> OnTypeRename { get; set; }
public Supports<LinkedEditingRangeClientCapabilities?> LinkedEditingRange { get; set; }

/// <summary>
/// Capabilities specific to `textDocument/publishDiagnostics`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace Models
GenerateHandlerMethods,
GenerateRequestMethods(typeof(ITextDocumentLanguageClient), typeof(ILanguageClient))
]
[RegistrationOptions(typeof(OnTypeRenameRegistrationOptions)), Capability(typeof(DocumentOnTypeFormattingCapability))]
[RegistrationOptions(typeof(DocumentOnTypeFormattingRegistrationOptions)), Capability(typeof(DocumentOnTypeFormattingCapability))]
public partial record DocumentOnTypeFormattingParams : ITextDocumentIdentifierParams, IRequest<TextEditContainer?>
{
/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@ namespace Models
{
[Parallel]
[Obsolete(Constants.Proposal)]
[Method(TextDocumentNames.OnTypeRename, Direction.ClientToServer)]
[Method(TextDocumentNames.LinkedEditingRange, Direction.ClientToServer)]
[
GenerateHandler("OmniSharp.Extensions.LanguageServer.Protocol.Document"),
GenerateHandlerMethods,
GenerateRequestMethods(typeof(ITextDocumentLanguageClient), typeof(ILanguageClient))
]
[RegistrationOptions(typeof(OnTypeRenameRegistrationOptions)), Capability(typeof(OnTypeRenameClientCapabilities))]
public partial record OnTypeRenameParams : TextDocumentPositionParams, IWorkDoneProgressParams, IRequest<OnTypeRenameRanges>
[RegistrationOptions(typeof(LinkedEditingRangeRegistrationOptions)), Capability(typeof(LinkedEditingRangeClientCapabilities))]
public partial record LinkedEditingRangeParams : TextDocumentPositionParams, IWorkDoneProgressParams, IRequest<LinkedEditingRanges>
{
}

[Obsolete(Constants.Proposal)]
public partial record OnTypeRenameRanges
public partial record LinkedEditingRanges
{
/// <summary>
/// A list of ranges that can be renamed together. The ranges must have
Expand All @@ -49,16 +49,16 @@ public partial record OnTypeRenameRanges
}

[Obsolete(Constants.Proposal)]
[GenerateRegistrationOptions(nameof(ServerCapabilities.OnTypeRenameProvider))]
public partial class OnTypeRenameRegistrationOptions : ITextDocumentRegistrationOptions, IWorkDoneProgressOptions { }
[GenerateRegistrationOptions(nameof(ServerCapabilities.LinkedEditingRangeProvider))]
public partial class LinkedEditingRangeRegistrationOptions : ITextDocumentRegistrationOptions, IWorkDoneProgressOptions { }

}

namespace Client.Capabilities
{
[Obsolete(Constants.Proposal)]
[CapabilityKey(nameof(ClientCapabilities.TextDocument), nameof(TextDocumentClientCapabilities.OnTypeRename))]
public partial class OnTypeRenameClientCapabilities : DynamicCapability, ConnectedCapability<IOnTypeRenameHandler> { }
[CapabilityKey(nameof(ClientCapabilities.TextDocument), nameof(TextDocumentClientCapabilities.LinkedEditingRange))]
public partial class LinkedEditingRangeClientCapabilities : DynamicCapability, ConnectedCapability<ILinkedEditingRangeHandler> { }
}

namespace Document
Expand Down
2 changes: 1 addition & 1 deletion src/Protocol/Server/Capabilities/ServerCapabilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public class ServerCapabilities : CapabilitiesBase
/// </summary>
[Optional]
[Obsolete(Constants.Proposal)]
public BooleanOr<OnTypeRenameRegistrationOptions.StaticOptions>? OnTypeRenameProvider { get; set; }
public BooleanOr<LinkedEditingRangeRegistrationOptions.StaticOptions>? LinkedEditingRangeProvider { get; set; }

/// <summary>
/// The server provides folding provider support.
Expand Down
2 changes: 1 addition & 1 deletion src/Protocol/TextDocumentNames.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ public static class TextDocumentNames
[Obsolete(Constants.Proposal)] public const string SemanticTokensFullDelta = "textDocument/semanticTokens/full/delta";
[Obsolete(Constants.Proposal)] public const string SemanticTokensRange = "textDocument/semanticTokens/range";
[Obsolete(Constants.Proposal)] public const string Moniker = "textDocument/moniker";
[Obsolete(Constants.Proposal)] public const string OnTypeRename = "textDocument/onTypeRename";
[Obsolete(Constants.Proposal)] public const string LinkedEditingRange = "textDocument/linkedEditingRange";
}
}