Skip to content

Updated to latest DAP spec #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 1, 2020
Merged

Updated to latest DAP spec #448

merged 9 commits into from
Dec 1, 2020

Conversation

david-driscoll
Copy link
Member

DAP Updates

  • This updates to the latest DAP spec, added in a few enums and replaced strings that were used in a few locations.
  • Added InvalidatedEvent

Generators

Added a generator for the new [StringEnum] attribute that requires a public readonly partial struct and generates an all the pieces needed to make an enum that accepts custom string values.

@david-driscoll david-driscoll added the breaking change This breaks existing behavior label Dec 1, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #448 (439a520) into master (5f3a5ac) will increase coverage by 71.54%.
The diff coverage is 99.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #448       +/-   ##
===========================================
+ Coverage        0   71.54%   +71.54%     
===========================================
  Files           0      251      +251     
  Lines           0    11908    +11908     
  Branches        0      813      +813     
===========================================
+ Hits            0     8520     +8520     
- Misses          0     3388     +3388     
Impacted Files Coverage Δ
src/Dap.Client/DebugAdapterClientOptions.cs 16.66% <ø> (ø)
src/JsonRpc/Generation/StringEnumAttribute.cs 0.00% <0.00%> (ø)
src/JsonRpc/NoopResponseRouter.cs 0.00% <0.00%> (ø)
...erialization/Converters/EnumLikeStringConverter.cs 66.66% <ø> (ø)
src/JsonRpc.Generators/EnumLikeStringGenerator.cs 99.30% <99.30%> (ø)
src/JsonRpc.Generators/GeneratorDiagnostics.cs 100.00% <100.00%> (ø)
src/JsonRpc/Events.cs 100.00% <100.00%> (ø)
...t/DebugAdapterClientServiceCollectionExtensions.cs 96.59% <0.00%> (ø)
src/JsonRpc/ProcessScheduler.cs 100.00% <0.00%> (ø)
src/Server/Logging/LanguageServerLoggingManager.cs 85.18% <0.00%> (ø)
... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3a5ac...439a520. Read the comment docs.

@david-driscoll david-driscoll merged commit caaf907 into master Dec 1, 2020
@mergify mergify bot deleted the feature/dap-update branch December 1, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This breaks existing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant