Skip to content

Feature/4 spec update #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Feature/4 spec update #446

merged 3 commits into from
Dec 1, 2020

Conversation

david-driscoll
Copy link
Member

Added two new library references

Microsoft.Extensions.Configuration.Binder and Microsoft.Extensions.Options.ConfigurationExtensions have been added to make integration between configuration and options a little easier.

CompletionItem TextEdit change

CompletionItem has been updated as the per the spec, to be a union of TextEdit and InsertRangeEdit.

Number types have changed

The spec added deeper definition for integer, unsigned integer and decimal

uinteger - Defines an unsigned integer number in the range of 0 to 2^31 - 1.
Due to this constraint it's easier for us to just keep using int instead of causing some headache by using uint.

long is now gone, replaced with int. Also a few places where precentage was allowed had been double but they have been changed to uint so they have been changed to int accordingly

Types with breaking changes:

  • FoldingRange
  • BooleanNumberString
  • IWorkDoneObserver
  • WorkDoneProgressBegin
  • WorkDoneProgressReport

Semantic Tokens Method

member has been renamed method as per the spec.

Auto-generated method perfixes have been updated

Request objects with the prefix "Set", "Attach", "Launch" or "Read" will no longer be prefixed with "Send" or "Request".

router.change affects the following:

  • Debug Adapter Protocol
    • SetVariableArguments - from router.SendSetVariable(...) to router.SetVariable()
    • AttachRequestArguments - from router.RequestAttach(...) to router.Attach()
    • LaunchRequestArguments - from router.RequestAttach(...) to router.Launch()
    • ReadMemoryArguments - from router.SendReadMemory(...) to router.ReadMemory()
    • SetBreakpointsArguments - from router.SendSetBreakpoints(...) to router.SetBreakpoints()
    • SetDataBreakpointsArguments - from router.SendSetDataBreakpoints(...) to router.SetDataBreakpoints()
    • SetExceptionBreakpointsArguments - from router.SendSetExceptionBreakpoints(...) to router.SetExceptionBreakpoints()
    • SetExpressionArguments - from router.SendSetExpression(...) to router.SetExpression()
    • SetFunctionBreakpointsArguments - from router.SendSetFunctionBreakpoints(...) to router.SetFunctionBreakpoints()
    • SetInstructionBreakpointsArguments - from router.SendSetInstructionBreakpoints(...) to router.SetInstructionBreakpoints()
  • Language Server Protocol
    • SetTraceParams - from router.SendSetTrace(...) to router.SetTrace()

@david-driscoll david-driscoll added the breaking change This breaks existing behavior label Dec 1, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 1, 2020
@david-driscoll david-driscoll linked an issue Dec 1, 2020 that may be closed by this pull request
@david-driscoll david-driscoll merged commit 21ebc56 into master Dec 1, 2020
@mergify mergify bot deleted the feature/4-spec-update branch December 1, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This breaks existing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP 0.16 - Automate TraceValue logging
1 participant