Breaking: LSP ISerializer interface is now deprecated, and marked obsolete #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
david-driscoll
commented
Nov 18, 2020
david-driscoll
commented
- LSP Serializer renamed to LSPSerializer
- Added serialization rules for client
- Ensure code actions are provided properly.
- Updated serialization rules for server
…olete. * LSP Serializer renamed to LSPSerializer * Added serialization rules for client * Ensure code actions are provided properly. * Updated serialization rules for server
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 78.16% 78.17% +0.01%
==========================================
Files 237 237
Lines 8647 8647
Branches 634 634
==========================================
+ Hits 6759 6760 +1
+ Misses 1888 1887 -1
Continue to review full report at Codecov.
|
|
Generally speaking this shouldn't break anyone, the custom serializer is used to manage the supported client/server tags, symbols, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.