Serially parallel

[david-driscoll]

Adds support for running requests that do not make changes to the workspace in parallel.

This is technically not officially supported by the spec but allows some things to speed up request handling

To disable it's possible to supply your own IRequestProcessIdentifier into LanguageServer.

[david-driscoll]

This has breaking changes (yay for sticking to 0.x versions at the moment, lol).
cc @tintoy

[tintoy]

I've been toying with the idea of using AKKA.NET to model background processing in my language service; assuming my code is already thread-safe do I still have anything to worry about?

[tintoy]

Sorry, I mean anything to worry about in the context of this change?

[tintoy]

BTW, my LSP client is concurrency-agnostic but I'll add some tests to make sure that's the still the case :)

[david-driscoll]

I don't think it would be a problem, as long as it's safe for each thread to call across. All this does it allows things like completion, and signature help which might fire at the same time, to both come back as fast as possible.

And if you want PR you're client into the repo I'd love to have it around! 👍

[tintoy]

Sure - I'll work up a PR sometime later this week :)

[tintoy]

@david-driscoll should I move it into the OmniSharp.Extensions.LanguageClient namespace? I'm fine with that, BTW.

[david-driscoll]

Yeah that's where I'd put it.

On Fri, Nov 3, 2017 at 4:47 PM Adam Friedman ***@***.***> wrote: @david-driscoll <https://github.com/david-driscoll> should I move it into the OmniSharp.Extensions.LanguageClient namespace? I'm fine with that, BTW. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNdpTuFMwhsH5qsP0qYBEXcwYjwiPHTks5sy3vrgaJpZM4QLq-4> .

-- Thanks, David

[tintoy]

I'm on it :)