Skip to content

Added warning message when a message is dropped during initialization #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented Nov 9, 2020

Both DAP and LSP define a set of messages that are "allowed during" the initialization hand shake. Today those messages are dropped behind the scenes, this set of changes will add some logs to let users know.

In addition for outgoing requests or notifications we will send them once initialization completes.

@david-driscoll david-driscoll added the enhancement New feature or request label Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #417 (897203b) into master (a08ad10) will decrease coverage by 0.00%.
The diff coverage is 72.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   72.97%   72.96%   -0.01%     
==========================================
  Files         576      582       +6     
  Lines       14205    14301      +96     
  Branches     1367     1371       +4     
==========================================
+ Hits        10366    10435      +69     
- Misses       3839     3866      +27     
Impacted Files Coverage Δ
src/Client/LanguageClient.cs 97.22% <ø> (ø)
src/Dap.Client/DebugAdapterClient.cs 100.00% <ø> (ø)
src/Dap.Server/DebugAdapterServer.cs 100.00% <ø> (ø)
test/TestingUtils/AutoNSubstitute/TestLogger.cs 6.25% <6.25%> (ø)
src/Server/LspServerReceiver.cs 64.00% <35.71%> (-13.15%) ⬇️
src/Client/LspClientReceiver.cs 75.00% <53.84%> (-16.90%) ⬇️
...sonRpc/JsonRpcServerServiceCollectionExtensions.cs 88.43% <66.66%> (-0.38%) ⬇️
src/Server/LspServerOutputFilter.cs 72.72% <72.72%> (ø)
.../TestingUtils/AutoNSubstitute/TestLoggerFactory.cs 92.68% <75.00%> (-4.10%) ⬇️
src/Client/LspClientOutputFilter.cs 76.47% <76.47%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08ad10...897203b. Read the comment docs.

@david-driscoll david-driscoll added the merge Shipit! label Nov 9, 2020
@github-actions github-actions bot added this to the v0.18.4 milestone Nov 9, 2020
@mergify mergify bot merged commit 9df048e into master Nov 9, 2020
@mergify mergify bot removed the merge Shipit! label Nov 9, 2020
@mergify mergify bot deleted the feature/warnings-on-message branch November 9, 2020 17:49
@github-actions github-actions bot modified the milestones: v0.18.4, v0.19.0 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant