Skip to content

ensure prepare rename does not try to register with the client #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

david-driscoll
Copy link
Member

Fixes #409

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Nov 6, 2020
@github-actions github-actions bot added this to the v0.18.3 milestone Nov 6, 2020
@david-driscoll david-driscoll changed the title ensure prepare rename does not try to register with vscode ensure prepare rename does not try to register with the client Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #414 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   72.61%   72.57%   -0.04%     
==========================================
  Files         569      569              
  Lines       13780    13780              
  Branches     1292     1292              
==========================================
- Hits        10006    10001       -5     
- Misses       3774     3779       +5     
Impacted Files Coverage Δ
src/Protocol/Document/IPrepareRenameHandler.cs 0.00% <ø> (ø)
src/JsonRpc/Server/Messages/ParseError.cs 0.00% <0.00%> (-100.00%) ⬇️
src/JsonRpc/InputHandler.cs 90.78% <0.00%> (-1.06%) ⬇️
src/Server/LanguageServerHelpers.cs 91.33% <0.00%> (+1.57%) ⬆️
test/TestingUtils/FactWithSkipOnAttribute.cs 100.00% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e961bdd...8241ebe. Read the comment docs.

@mergify mergify bot merged commit 300ef94 into master Nov 6, 2020
@mergify mergify bot removed the merge Shipit! label Nov 6, 2020
@mergify mergify bot deleted the fix/preapre-rename branch November 6, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrepareRename does not work with VSCode client
1 participant