Skip to content

additional nullable annotation cleanup #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2020
Merged

additional nullable annotation cleanup #384

merged 2 commits into from
Oct 5, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added chore Just keeping things neat and tidy merge Shipit! labels Oct 5, 2020
@github-actions github-actions bot added this to the v0.18.1 milestone Oct 5, 2020
@david-driscoll david-driscoll removed the merge Shipit! label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #384 into master will decrease coverage by 0.01%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   75.75%   75.73%   -0.02%     
==========================================
  Files         561      561              
  Lines       13508    13511       +3     
  Branches     1244     1269      +25     
==========================================
  Hits        10233    10233              
- Misses       3275     3278       +3     
Impacted Files Coverage Δ
src/Client/LangaugeClientRegistry.cs 100.00% <ø> (ø)
...lient/LanguageClientServiceCollectionExtensions.cs 96.93% <ø> (ø)
src/Dap.Client/DefaultDebugAdapterClientFacade.cs 100.00% <ø> (ø)
src/Dap.Shared/DapResponseRouter.cs 85.41% <ø> (ø)
src/JsonRpc.Testing/JsonRpcServerTestBase.cs 100.00% <ø> (ø)
src/JsonRpc/HandlerCollection.cs 72.00% <ø> (ø)
src/JsonRpc/JsonRpcHandlerCollectionExtensions.cs 89.28% <ø> (ø)
src/JsonRpc/JsonRpcServer.cs 100.00% <ø> (ø)
src/JsonRpc/RequestRouterBase.cs 100.00% <ø> (ø)
src/JsonRpc/ResponseRouter.cs 86.11% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad2787...eb9e8fc. Read the comment docs.

@david-driscoll david-driscoll added the merge Shipit! label Oct 5, 2020
@mergify mergify bot merged commit 0b9561b into master Oct 5, 2020
@mergify mergify bot removed the merge Shipit! label Oct 5, 2020
@mergify mergify bot deleted the chore/nullability branch October 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Just keeping things neat and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant