Skip to content

Fixed document color handler and params #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

david-driscoll
Copy link
Member

Fixes #381

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Oct 4, 2020
@github-actions github-actions bot added this to the v0.18.1 milestone Oct 4, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files         561      561           
  Lines       13508    13508           
  Branches     1244     1266   +22     
=======================================
  Hits        10233    10233           
  Misses       3275     3275           
Impacted Files Coverage Δ
src/Protocol/Document/IDocumentColorHandler.cs 0.00% <ø> (ø)
src/Protocol/Models/DocumentColorParams.cs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1d7f6...2d7474b. Read the comment docs.

@mergify mergify bot merged commit 0ad2787 into master Oct 5, 2020
@mergify mergify bot removed the merge Shipit! label Oct 5, 2020
@mergify mergify bot deleted the fix/textDocument/documentColor branch October 5, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentColorHandler should return ColorInformation but returns ColorPresentation
1 participant