Skip to content

Added some additional nullable annotations #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added chore Just keeping things neat and tidy merge Shipit! labels Oct 3, 2020
@github-actions github-actions bot added this to the v0.18.1 milestone Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #380 into master will increase coverage by 0.03%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   75.23%   75.26%   +0.03%     
==========================================
  Files         556      555       -1     
  Lines       13034    13047      +13     
  Branches     1190     1193       +3     
==========================================
+ Hits         9806     9820      +14     
+ Misses       3228     3227       -1     
Impacted Files Coverage Δ
...ient/Configuration/ChainedConfigurationProvider.cs 75.86% <ø> (ø)
...ient/Configuration/ChainedConfigurationProvider.cs 17.24% <ø> (ø)
...Client/Configuration/ChainedConfigurationSource.cs 0.00% <0.00%> (ø)
...rver/Configuration/ChainedConfigurationProvider.cs 17.24% <ø> (ø)
...Server/Configuration/ChainedConfigurationSource.cs 0.00% <0.00%> (ø)
src/JsonRpc/NoopResponseRouter.cs 0.00% <0.00%> (ø)
src/JsonRpc/RequestRouterBase.cs 100.00% <ø> (ø)
src/Protocol/LanguageProtocolDelegatingHandlers.cs 41.57% <ø> (ø)
src/Protocol/Models/DocumentSelector.cs 78.94% <ø> (ø)
src/Protocol/Models/Position.cs 63.15% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cebed1...4bb2ad6. Read the comment docs.

@mergify mergify bot merged commit ee04c9a into master Oct 4, 2020
@mergify mergify bot removed the merge Shipit! label Oct 4, 2020
@mergify mergify bot deleted the feature/nullability-2 branch October 4, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Just keeping things neat and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant