Skip to content

Fix/prepare rename #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Fix/prepare rename #379

merged 3 commits into from
Oct 3, 2020

Conversation

david-driscoll
Copy link
Member

Fixes #372

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Oct 3, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #379 into master will increase coverage by 0.04%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   75.36%   75.41%   +0.04%     
==========================================
  Files         443      443              
  Lines       12779    12790      +11     
  Branches     1183     1171      -12     
==========================================
+ Hits         9631     9645      +14     
+ Misses       3148     3145       -3     
Impacted Files Coverage Δ
...ion/Converters/RangeOrPlaceholderRangeConverter.cs 86.36% <76.92%> (+4.54%) ⬆️
src/Protocol/Models/RangeOrPlaceholderRange.cs 55.17% <0.00%> (+3.44%) ⬆️
src/Protocol/Models/RenameRegistrationOptions.cs 100.00% <0.00%> (+37.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332e5ae...583517b. Read the comment docs.

@mergify mergify bot merged commit 4911dba into master Oct 3, 2020
@mergify mergify bot removed the merge Shipit! label Oct 3, 2020
@mergify mergify bot deleted the fix/prepare-rename branch October 3, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrepareRead serialisation failed
1 participant