Skip to content

Made position comparable #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Made position comparable #378

merged 1 commit into from
Oct 3, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added enhancement New feature or request merge Shipit! labels Oct 3, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Oct 3, 2020
@david-driscoll
Copy link
Member Author

fixes #376

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #378 into master will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   75.38%   75.36%   -0.02%     
==========================================
  Files         443      443              
  Lines       12764    12779      +15     
  Branches     1162     1168       +6     
==========================================
+ Hits         9622     9631       +9     
- Misses       3142     3148       +6     
Impacted Files Coverage Δ
src/Protocol/Models/Position.cs 68.42% <60.00%> (-5.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eeb011...e83935b. Read the comment docs.

@mergify mergify bot merged commit 332e5ae into master Oct 3, 2020
@mergify mergify bot removed the merge Shipit! label Oct 3, 2020
@mergify mergify bot deleted the feature/comparable-position branch October 3, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant