Skip to content

Fixed case where dynamic registration would fail if Register is called before Initialize #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

david-driscoll
Copy link
Member

Turns out there is a race condition anyway where supported capabilities aren't loaded yet, and wouldn't be detected.

@david-driscoll david-driscoll added the bug Something isn't working label Sep 2, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #348 into master will increase coverage by 0.13%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   75.35%   75.48%   +0.13%     
==========================================
  Files         441      441              
  Lines       12742    12774      +32     
  Branches     1180     1179       -1     
==========================================
+ Hits         9602     9643      +41     
+ Misses       3140     3131       -9     
Impacted Files Coverage Δ
src/Server/LanguageServerHelpers.cs 90.59% <98.07%> (+2.22%) ⬆️
src/Server/DefaultLanguageServerFacade.cs 82.35% <100.00%> (+0.53%) ⬆️
src/Server/LanguageServer.cs 96.47% <100.00%> (ø)
src/Protocol/Models/UnregistrationContainer.cs 46.66% <0.00%> (ø)
src/Protocol/Models/RegistrationContainer.cs 66.66% <0.00%> (+8.33%) ⬆️
src/Testing/ClientCapabilityExtensions.cs 100.00% <0.00%> (+64.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d9466...d3599f8. Read the comment docs.

@david-driscoll david-driscoll merged commit 8065672 into master Sep 2, 2020
@mergify mergify bot deleted the fix/dynamic-registration branch September 2, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant