Skip to content

fixed an issue where workspace folders could be null, and this would cause issues #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

david-driscoll
Copy link
Member

fixes #345

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Sep 1, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #346 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   75.37%   75.35%   -0.03%     
==========================================
  Files         441      441              
  Lines       12741    12742       +1     
  Branches     1180     1180              
==========================================
- Hits         9604     9602       -2     
- Misses       3137     3140       +3     
Impacted Files Coverage Δ
src/Server/LanguageServerWorkspaceFolderManager.cs 93.54% <100.00%> (+0.10%) ⬆️
src/Protocol/Models/WorkspaceFolder.cs 73.68% <0.00%> (-10.53%) ⬇️
...rc/Client/LanguageClientWorkspaceFoldersManager.cs 94.73% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c451a74...362168e. Read the comment docs.

@mergify mergify bot merged commit 09d9466 into master Sep 1, 2020
@mergify mergify bot removed the merge Shipit! label Sep 1, 2020
@mergify mergify bot deleted the fix/gh-345 branch September 1, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting a language server in VS Code with no open folders takes down the server
1 participant