Fixed DocumentTextSync converter / Added semantic token refresh notification #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
commented
Sep 1, 2020
| @@ -334,48 +334,48 @@ public RequestCapability(Guid id, Func<TParams, TCapability, CancellationToken, | |||
| void ICapability<TCapability>.SetCapability(TCapability capability) => _capability = capability; | |||
| } | |||
|
|
|||
| public sealed class PartialResult<TItem, TResponse, TCapability, TRegistrationOptions> : | |||
| IJsonRpcRequestHandler<TItem, TResponse>, | |||
| public sealed class PartialResult<TParams, TResponse, TItem, TCapability, TRegistrationOptions> : | |||
There was a problem hiding this comment.
These were wrong. Since nothing had used them yet, we didn't know.
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 75.60% 75.37% -0.23%
==========================================
Files 428 441 +13
Lines 12497 12741 +244
Branches 1132 1165 +33
==========================================
+ Hits 9448 9604 +156
- Misses 3049 3137 +88
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.