Fixed stackoverflow if you tried to resolve the LanguageServer while it was being constructed #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to resolve the LanguageServer while it was being constructed
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 70.11% 75.30% +5.18%
==========================================
Files 421 427 +6
Lines 12269 12434 +165
Branches 1127 1119 -8
==========================================
+ Hits 8603 9363 +760
+ Misses 3249 3071 -178
+ Partials 417 0 -417
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following types will not be resolvable during construction by
IJsonRpcHandlers that are added at initialization time.IJsonRpcServer/JsonRpcServerILanguageServer/LanguageServerILanguageClient/LanguageClientIDebugAdapterServer/DebugAdapterServerIDebugAdapterClient/DebugAdapterClientIn the event you need to access those interfaces, you can use the following
Facadeinterfaces, that are resolvable anytime.IJsonRpcServerFacadeILanguageServerFacadeILanguageClientFacadeIDebugAdapterServerFacadeIDebugAdapterClientFacadeNOTE: This is a breaking change from the versions before that did use DryIoc internally, however the facade interface gives a smooth path forward.