Porting over the minor breaking changes from the nullablity branch to be included in 0.18 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be included in 0.18
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 75.21% 70.11% -5.10%
==========================================
Files 420 421 +1
Lines 12249 12269 +20
Branches 1112 1127 +15
==========================================
- Hits 9213 8603 -610
- Misses 3036 3249 +213
- Partials 0 417 +417
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not turn on nullability in anyway just introduces be basic building blocks
EmptyRequestwas not longer used (and it's usage was confusing)IJsonRpcNotificationHandlerhas been removed (no longer needed with delegating handlers)IPartialItemsRequest<>has been removed (IPartialItemsRequest<,>still exists) as it was causing issues with setting proper nullability of partial request items, as it was just a convenience interface anyway.IResponseRouter.GetRequestRemoved - Routers are mainly internal bits and having the tuple return type caused nullability issues.IResponseRouter.TryGetRequestAdded - has the proper nullable notations so nullability just flows through.