Skip to content

IHandlersManager and Handler linking improvments #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Conversation

david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented Aug 25, 2020

  • Added extension method to get all the unique handlers contained in the IHandlersManager
  • Renamed link parameter names to better reflect their meaning.
    • Added some better exceptions here to help users in the future.

@david-driscoll david-driscoll added the enhancement New feature or request label Aug 25, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Aug 25, 2020
…ded exceptions to help users diagnose issues
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #334 into master will increase coverage by 0.00%.
The diff coverage is 72.34%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files         420      421    +1     
  Lines       12249    12282   +33     
  Branches     1112     1118    +6     
=======================================
+ Hits         9213     9238   +25     
- Misses       3036     3044    +8     
Impacted Files Coverage Δ
src/Client/LanguageClientOptions.cs 33.33% <0.00%> (ø)
src/Dap.Client/DebugAdapterClientOptions.cs 14.28% <0.00%> (ø)
src/Dap.Server/DebugAdapterServerOptions.cs 17.14% <0.00%> (ø)
src/JsonRpc/JsonRpcCommonMethodsBase.cs 47.16% <ø> (ø)
src/JsonRpc/JsonRpcOptionsRegistryBase.cs 80.00% <0.00%> (ø)
src/Server/LanguageServerOptions.cs 23.52% <0.00%> (ø)
src/JsonRpc/HandlerCollection.cs 68.83% <33.33%> (-7.29%) ⬇️
src/Dap.Shared/DebugAdapterHandlerCollection.cs 83.08% <100.00%> (+1.34%) ⬆️
src/JsonRpc/CompositeHandlersManager.cs 97.43% <100.00%> (ø)
src/JsonRpc/HandlersManagerExtensions.cs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085ef9c...7a1565f. Read the comment docs.

@david-driscoll david-driscoll changed the title Added extension method to get all the unique handlers contained in the IHandlersManager IHandlersManager and Handler linking improvments Aug 25, 2020
@david-driscoll david-driscoll merged commit 2311cbb into master Aug 26, 2020
@mergify mergify bot deleted the fix/links branch August 26, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant