Skip to content

Null reference types #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 3, 2020
Merged

Null reference types #330

merged 12 commits into from
Oct 3, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v0.18.0 milestone Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #330 into master will decrease coverage by 0.17%.
The diff coverage is 65.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   75.41%   75.23%   -0.18%     
==========================================
  Files         443      556     +113     
  Lines       12790    13034     +244     
  Branches     1186     1190       +4     
==========================================
+ Hits         9645     9806     +161     
- Misses       3145     3228      +83     
Impacted Files Coverage Δ
...rc/Client/LanguageClientWorkspaceFoldersManager.cs 92.98% <0.00%> (-1.76%) ⬇️
...rc/Dap.Client/DebugAdapterClientProgressManager.cs 37.50% <0.00%> (-3.13%) ⬇️
src/Dap.Protocol/DapReceiver.cs 100.00% <ø> (ø)
src/Dap.Protocol/Events/BreakpointEvent.cs 0.00% <0.00%> (ø)
src/Dap.Protocol/Events/CapabilitiesEvent.cs 0.00% <0.00%> (ø)
src/Dap.Protocol/Events/LoadedSourceEvent.cs 0.00% <0.00%> (ø)
src/Dap.Protocol/Events/ModuleEvent.cs 0.00% <0.00%> (ø)
src/Dap.Protocol/Events/OutputEvent.cs 0.00% <0.00%> (ø)
src/Dap.Protocol/Events/ProcessEvent.cs 0.00% <0.00%> (ø)
src/Dap.Protocol/Events/ProgressStartEvent.cs 0.00% <0.00%> (ø)
... and 414 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422460b...e12f6f1. Read the comment docs.

Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too big to review in GH... I'll checkout and check it locally at some point,

@@ -12,7 +12,7 @@
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=EnforceUsingStatementBraces/@EntryIndexedValue">WARNING</s:String>
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=EnforceWhileStatementBraces/@EntryIndexedValue">WARNING</s:String>
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=RemoveRedundantBraces/@EntryIndexedValue">WARNING</s:String>
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnnecessaryWhitespace/@EntryIndexedValue">WARNING</s:String>
<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnnecessaryWhitespace/@EntryIndexedValue">DO_NOT_SHOW</s:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What! You're trying to mess with my OCD?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol... probably a mistake.

@david-driscoll david-driscoll force-pushed the feature/nullability branch 2 times, most recently from 141c4b8 to 952c933 Compare August 26, 2020 00:59
@david-driscoll david-driscoll merged commit 9cebed1 into master Oct 3, 2020
@github-actions github-actions bot added the mysterious We forgot to label this label Oct 3, 2020
@mergify mergify bot deleted the feature/nullability branch October 3, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants