Skip to content

Refactored static HandlerTypeDescriptorHelper to injected as HandlerTypeDescriptorProvider #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Aug 15, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Aug 15, 2020
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #319 into master will increase coverage by 0.21%.
The diff coverage is 89.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   74.35%   74.56%   +0.21%     
==========================================
  Files         415      415              
  Lines       12004    12085      +81     
  Branches     1118     1119       +1     
==========================================
+ Hits         8925     9011      +86     
+ Misses       3079     3074       -5     
Impacted Files Coverage Δ
src/Client/LanguageClientOptionsExtensions.cs 38.54% <0.00%> (ø)
src/JsonRpc.Testing/JsonRpcTestOptions.cs 25.00% <0.00%> (-1.67%) ⬇️
...rc/JsonRpc.Testing/JsonRpcTestOptionsExtensions.cs 50.00% <0.00%> (-16.67%) ⬇️
src/Server/LanguageServerOptionsExtensions.cs 41.66% <0.00%> (-3.79%) ⬇️
src/Client/LanguageClientRegistrationManager.cs 68.51% <87.50%> (+1.21%) ⬆️
src/JsonRpc/HandlerTypeDescriptorProvider.cs 87.36% <89.65%> (ø)
...rotocol/Shared/LspHandlerTypeDescriptorProvider.cs 93.10% <93.10%> (ø)
src/Client/LanguageClientOptions.cs 33.33% <100.00%> (+4.76%) ⬆️
...lient/LanguageClientServiceCollectionExtensions.cs 96.59% <100.00%> (+2.33%) ⬆️
src/Client/LspClientReceiver.cs 92.10% <100.00%> (+0.92%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5571121...cfb15d5. Read the comment docs.

@david-driscoll david-driscoll merged commit 8411ac4 into master Aug 15, 2020
@mergify mergify bot removed the merge Shipit! label Aug 15, 2020
@mergify mergify bot deleted the fix/static-type-descriptor branch August 15, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant