Skip to content

Fixed configuration issue where data was being cleared of previous sections #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Aug 15, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Aug 15, 2020
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #317 into master will increase coverage by 0.20%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   74.14%   74.35%   +0.20%     
==========================================
  Files         413      415       +2     
  Lines       11827    12004     +177     
  Branches     1105     1104       -1     
==========================================
+ Hits         8769     8925     +156     
- Misses       3058     3079      +21     
Impacted Files Coverage Δ
src/Testing/LanguageServerTestBase.cs 100.00% <ø> (ø)
...ol/Server/LanguageServerConfigurationExtensions.cs 33.33% <33.33%> (ø)
src/Server/Configuration/ConfigurationConverter.cs 59.15% <66.66%> (ø)
src/Protocol/Models/ConfigurationItem.cs 82.35% <82.35%> (ø)
...er/Configuration/DidChangeConfigurationProvider.cs 88.74% <95.45%> (+20.17%) ⬆️
src/Server/Configuration/ScopedConfiguration.cs 73.07% <100.00%> (ø)
...er/Configuration/WorkspaceConfigurationProvider.cs 100.00% <100.00%> (ø)
...rver/Configuration/WorkspaceConfigurationSource.cs 100.00% <100.00%> (ø)
...erver/LanguageServerServiceCollectionExtensions.cs 94.79% <100.00%> (+0.40%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1497f35...b55dc5e. Read the comment docs.

@david-driscoll david-driscoll merged commit 5571121 into master Aug 15, 2020
@mergify mergify bot removed the merge Shipit! label Aug 15, 2020
@mergify mergify bot deleted the fix/server-configuration branch August 15, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant