Skip to content

Added fixture based tests and re-enabled disabled tests #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 14, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v0.18.0 milestone Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #310 into master will increase coverage by 0.76%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   73.18%   73.94%   +0.76%     
==========================================
  Files         415      415              
  Lines       11772    11838      +66     
  Branches     1092     1093       +1     
==========================================
+ Hits         8615     8754     +139     
+ Misses       3157     3084      -73     
Impacted Files Coverage Δ
src/Client/LanguageClientOptions.cs 28.57% <0.00%> (-0.70%) ⬇️
src/Dap.Client/DebugAdapterClientOptions.cs 3.22% <0.00%> (-0.11%) ⬇️
src/Dap.Protocol/Models/ProgressToken.cs 12.50% <ø> (ø)
src/Dap.Server/DebugAdapterServerOptions.cs 6.45% <0.00%> (-0.22%) ⬇️
src/JsonRpc.Testing/JsonRpcTestOptions.cs 26.66% <0.00%> (+6.66%) ⬆️
src/JsonRpc/JsonRpcCommonMethodsBase.cs 47.16% <ø> (ø)
src/JsonRpc/JsonRpcOptionsRegistryBase.cs 80.00% <0.00%> (-7.81%) ⬇️
src/Server/LanguageServerOptions.cs 14.28% <0.00%> (-0.43%) ⬇️
src/JsonRpc/CompositeHandlersManager.cs 46.15% <20.00%> (+4.04%) ⬆️
...rc/JsonRpc.Testing/JsonRpcTestOptionsExtensions.cs 66.66% <66.66%> (-16.67%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6703457...69b5975. Read the comment docs.

@david-driscoll david-driscoll merged commit 79c95bc into master Aug 14, 2020
@github-actions github-actions bot added the mysterious We forgot to label this label Aug 14, 2020
@mergify mergify bot deleted the chore/fix-tests branch August 14, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant