Skip to content

Added support for custom handlers that can replace / work side-by-side with existing handlers #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

david-driscoll
Copy link
Member

Added support for class based handlers to HandlerTypeDescriptorHelper/LspHandlerTypeDescriptorHelper.
Added unit test demonstrating a custom params / handler pair for Execute Command
Made the OptionalAttribute's public
Added IExecuteCommandParams to allow for custom command execution handlers to work correctly.

fixes: #308

…/LspHandlerTypeDescriptorHelper.

Added unit test demonstrating a custom params / handler pair for Execute Command
Made the OptionalAttribute's public
Added IExecuteCommandParams to allow for custom command execution handlers to work correctly.
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #309 into master will decrease coverage by 5.20%.
The diff coverage is 81.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   73.20%   67.99%   -5.21%     
==========================================
  Files         415      415              
  Lines       11743    11772      +29     
  Branches     1101     1105       +4     
==========================================
- Hits         8596     8004     -592     
- Misses       3147     3363     +216     
- Partials        0      405     +405     
Impacted Files Coverage Δ
src/Server/Matchers/ExecuteCommandMatcher.cs 100.00% <ø> (ø)
src/JsonRpc/HandlerTypeDescriptor.cs 66.66% <28.57%> (-33.34%) ⬇️
src/Client/LanguageClientRegistrationManager.cs 50.96% <50.00%> (-5.77%) ⬇️
src/JsonRpc/HandlerTypeDescriptorHelper.cs 85.10% <81.81%> (-1.50%) ⬇️
.../Protocol/Shared/LspHandlerTypeDescriptorHelper.cs 86.36% <93.75%> (+2.15%) ⬆️
src/Dap.Shared/DebugAdapterHandlerCollection.cs 77.86% <100.00%> (-3.28%) ⬇️
src/JsonRpc/InputHandler.cs 84.63% <100.00%> (-5.45%) ⬇️
src/Shared/LspRequestRouter.cs 86.27% <100.00%> (-11.77%) ⬇️
src/Shared/SharedHandlerCollection.cs 72.42% <100.00%> (-3.28%) ⬇️
src/Protocol/Models/Hover.cs 50.00% <0.00%> (-50.00%) ⬇️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d53a6e...51b863d. Read the comment docs.

@david-driscoll david-driscoll merged commit 6703457 into master Aug 14, 2020
@github-actions github-actions bot added the mysterious We forgot to label this label Aug 14, 2020
@mergify mergify bot deleted the feature/better-custom-handlers branch August 14, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for a response body on "workspace/executeCommand"
1 participant