Skip to content

Added the ability to use strongly typed data fields with codelens, completion and documentlink #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2020

Conversation

david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented Jul 31, 2020

This enables multiple handlers to be registered for a given document selector for Code Lens, Completion and Document Link.

  • This can be used to have a code lens provider for unit tests, and a different one for references (as an example).
  • the resolved data must now be an object to ensure that we can route the data properly.
  • This includes a few minor breaking changes.
    • CanResolve has been removed since the built in routing will ensure that the handler that created the codelens/completion/documentlink is the one that is called to resolve.
    • The internals have been changed to return multiple descriptors instead of a single one.

+semver:minor.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #269 into master will increase coverage by 2.15%.
The diff coverage is 71.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   61.60%   63.75%   +2.15%     
==========================================
  Files         352      356       +4     
  Lines       10461    11418     +957     
  Branches     1208     1315     +107     
==========================================
+ Hits         6444     7280     +836     
- Misses       3639     3701      +62     
- Partials      378      437      +59     
Impacted Files Coverage Δ
src/JsonRpc/Client/OutgoingResponse.cs 54.54% <ø> (ø)
src/Protocol/AbstractHandlers.cs 22.00% <ø> (+22.00%) ⬆️
src/Protocol/Document/ITextDocumentSyncHandler.cs 0.00% <ø> (ø)
src/Protocol/Workspace/IExecuteCommandHandler.cs 95.00% <0.00%> (+0.83%) ⬆️
src/Shared/SupportedCapabilities.cs 86.11% <0.00%> (+33.33%) ⬆️
src/Protocol/Models/CompletionList.cs 24.19% <11.76%> (-11.53%) ⬇️
src/Protocol/Models/CodeLensContainer.cs 35.71% <25.00%> (-14.29%) ⬇️
src/Protocol/Models/DocumentLinkContainer.cs 35.71% <25.00%> (+35.71%) ⬆️
src/Protocol/DelegatingHandlers.cs 31.84% <28.84%> (+3.47%) ⬆️
src/Server/Pipelines/ResolveCommandPipeline.cs 88.00% <33.33%> (-4.31%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40c9ce...fcbffef. Read the comment docs.

@david-driscoll david-driscoll merged commit 7c6bbaf into master Aug 1, 2020
@david-driscoll david-driscoll deleted the feature/typed-resolve branch August 1, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant