Skip to content

Commands, bugs, helpers and more! #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2020
Merged

Commands, bugs, helpers and more! #268

merged 6 commits into from
Jul 31, 2020

Conversation

david-driscoll
Copy link
Member

  • Fixes a bug where if only one command is registered, it's called even if the command that is being executed has a different name.
  • Fixes a bug where only one command handler could be registered at a time (effectively).
  • Adds a method for executing a Command directory on the client (retrieved from completions for example)
  • Adds OnExecuteCommand<T[, [T2, [T3, [T4, [T5, [T6]]]]]>
    • These handlers will automatically deserialize the arguments from the arguments JArray

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #268 into master will increase coverage by 0.63%.
The diff coverage is 90.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   60.96%   61.60%   +0.63%     
==========================================
  Files         352      352              
  Lines       10336    10461     +125     
  Branches     1169     1208      +39     
==========================================
+ Hits         6301     6444     +143     
+ Misses       3664     3636      -28     
- Partials      371      381      +10     
Impacted Files Coverage Δ
src/Server/Matchers/TextDocumentMatcher.cs 78.43% <50.00%> (-2.82%) ⬇️
src/Shared/LspRequestRouter.cs 85.36% <60.00%> (+6.41%) ⬆️
src/Shared/SharedHandlerCollection.cs 69.36% <83.33%> (+0.56%) ⬆️
src/Protocol/Workspace/IExecuteCommandHandler.cs 94.16% <94.73%> (+94.16%) ⬆️
src/JsonRpc.Generators/Helpers.cs 57.58% <100.00%> (+0.05%) ⬆️
src/Protocol/DelegatingHandlers.cs 28.37% <0.00%> (+1.62%) ⬆️
src/Server/LanguageServerOptions.cs 23.68% <0.00%> (+2.63%) ⬆️
src/JsonRpc.Testing/JsonRpcTestBase.cs 100.00% <0.00%> (+6.25%) ⬆️
src/JsonRpc/JsonRpcOptionsRegistryBase.cs 71.76% <0.00%> (+12.94%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4ecc5...65869f1. Read the comment docs.

@david-driscoll david-driscoll merged commit a40c9ce into master Jul 31, 2020
@david-driscoll david-driscoll deleted the fix/commands branch July 31, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant