Debug Adapter Server / Client update

[david-driscoll]

This updates to the latest version of the Debug Adapter Protocol bringing in some of the missing pieces, cancellation, progress and a few other things.

Also adds support for a Server / Client pair exactly like Language Server Protocol has, these are super awesome in testing scenarios.

• The initialization process is handled.
• Progress can be sent from the server to the client.
• Cancellation is now supported
  • This required some gymnastics to get right
  • The cancel handler (implemented by IServerProgressManager will get essentially empty requests for request cancellation, as they get re-routed down the normal cancellation path as provided by the rest of the json rpc bits.
• The data sent from the server to the client includes the LSP error codes, which are used to re-hydrate the proper exception types on the client side.

Minor change to some types (though they are really only used on the the internals) to include a method, this was to properly fix serialization of DAP responses.

[david-driscoll]

cc @TylerLeonhardt @rjmholt

[codecov]

Codecov Report

Merging #267 into master will increase coverage by 0.34%.
The diff coverage is 67.46%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   63.75%   64.10%   +0.34%     
==========================================
  Files         356      374      +18     
  Lines       11418    12394     +976     
  Branches     1315     1419     +104     
==========================================
+ Hits         7280     7945     +665     
- Misses       3704     3978     +274     
- Partials      434      471      +37     

Impacted Files	Coverage Δ
src/Dap.Protocol/Models/Module.cs	0.00% <0.00%> (ø)
src/Dap.Protocol/Serialization/ContractResolver.cs	0.00% <0.00%> (ø)
src/Dap.Testing/LanguageServerTestBase.cs	0.00% <0.00%> (ø)
src/JsonRpc.Testing/AggregateSettler.cs	100.00% <ø> (ø)
src/JsonRpc.Testing/SettlePipeline.cs	100.00% <ø> (ø)
src/JsonRpc.Testing/Settler.cs	84.37% <ø> (ø)
...nRpc/Generation/GenerateHandlerMethodsAttribute.cs	0.00% <ø> (ø)
src/JsonRpc/RequestRouterBase.cs	87.17% <ø> (ø)
src/JsonRpc/Server/Messages/ParseError.cs	0.00% <0.00%> (ø)
src/Server/LspServerReceiver.cs	60.60% <0.00%> (ø)
... and 75 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6bbaf...40e8319. Read the comment docs.

[TylerLeonhardt]

Some things I wanna make sure are addressed are:

• How do we extend the launch and attach messages? Currently, we redefine our own type.https://github.com/PowerShell/PowerShellEditorServices/blob/master/src/PowerShellEditorServices/Services/DebugAdapter/Handlers/LaunchAndAttachHandler.cs#L30-L95
• How could I disconnect and then later connect to a debug adapter server? Currently, we do this horrible event stuff where we:
  • Trigger this event In the "disconnect" message
  • That Disposes of the old server and restarts it (YUCK)

[david-driscoll]

I knew there were pieces I need to make sure got updated, thanks I'll look at this tonight.

[david-driscoll]

@TylerLeonhardt have any thoughts on how to make it so those requests are more flexible?

I can make it a Dictionary or add a [JsonExtensionData] property... however none of those will be "strongly" typed. Re-defining it honestly seems like the better approach. Perhaps if you derived from the requests themselves and added the properties you want.... I'm not sure.

I didn't get to the second point today, I'll look at that tomorrow.

[TylerLeonhardt]

👀👀👀👀👀👀