Skip to content

Added request and response processors that ensures they are not null #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

david-driscoll
Copy link
Member

This is a simple change to ensure that null requests and null responses (through the MediatR pipeline) throws an error.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #265 into master will increase coverage by 0.07%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   60.88%   60.96%   +0.07%     
==========================================
  Files         350      352       +2     
  Lines       10328    10336       +8     
  Branches     1167     1169       +2     
==========================================
+ Hits         6288     6301      +13     
+ Misses       3673     3664       -9     
- Partials      367      371       +4     
Impacted Files Coverage Δ
...JsonRpc/Pipelines/RequestMustNotBeNullProcessor.cs 60.00% <60.00%> (ø)
...sonRpc/Pipelines/ResponseMustNotBeNullProcessor.cs 60.00% <60.00%> (ø)
src/JsonRpc/ServiceCollectionExtensions.cs 88.88% <100.00%> (-1.12%) ⬇️
src/Server/LanguageServer.Shutdown.cs 62.06% <0.00%> (ø)
src/JsonRpc/RequestRouterBase.cs 85.08% <0.00%> (+4.38%) ⬆️
src/JsonRpc/Server/Messages/InvalidParams.cs 50.00% <0.00%> (+50.00%) ⬆️
src/JsonRpc/Server/InvalidParametersException.cs 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93f973...cbde250. Read the comment docs.

@david-driscoll david-driscoll merged commit 7d4ecc5 into master Jul 28, 2020
@david-driscoll david-driscoll deleted the feature/handle-null-request-response branch July 28, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant