Skip to content

Fixes #214 by returning LSP conform JSON for prepare rename request #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2020

Conversation

drsoran
Copy link
Contributor

@drsoran drsoran commented Mar 8, 2020

This will add a new converter for RangeOrPlaceholderRange to the Serializer.

@RangeOrPlaceholderRangeConverter

I let CanRead return false because the client will never send such an object. I also return an empty RangeOrPlaceholderRange in case of Read. Not sure, perhaps it`s better to return null or throw?

Fixes #214

@dnfclas
Copy link

dnfclas commented Mar 8, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ drsoran sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@drsoran drsoran changed the title Fixes #175 by returning LSP conform JSON for prepare rename request Fixes #214 by returning LSP conform JSON for prepare rename request Mar 8, 2020
@david-driscoll
Copy link
Member

@drsoran thanks! I'll get this in today.

@david-driscoll david-driscoll merged commit 760d696 into OmniSharp:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Rename request handler returns wrong JSON
3 participants