Skip to content

Always return result property on success #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

Always return result property on success #203

merged 1 commit into from
Jan 21, 2020

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes #202.

david-driscoll
david-driscoll approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @ryanbrandenburg !

@david-driscoll david-driscoll merged commit a8e44c2 into OmniSharp:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-driscoll david-driscoll david-driscoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response.Result of null should still be serialized
2 participants
@ryanbrandenburg @david-driscoll