Adds ILoggingBuilder extension for LanguageServer logging.

[bjorkstromm]

replaces AddDefaultLoggingProvider() with .AddLanguageServer().

Allows you to pass in a LogLevel into .AddLanguageServer() (default is Information)

[bjorkstromm]

I'd like to avoid having this, but truth is that MEL adds a default filter which works on the factory level, so we won't get our logs to LSP logger if they are < Information (which is default),

[tintoy]

As long as it's configured by the consumer (read: Host process) I think that's fine.

[bjorkstromm]

Best would be if we'd also here could notify IOptionsMonitor<LoggerFilterOptions> that it has changed. Without a configuration file, we'd probably have to do something like this. https://stackoverflow.com/a/53077453

[david-driscoll]

We should probably look at a configuration integration. My thought is something like interface ILspConfiguration : IConfiguration and then populate that some defaults, like the logging state, but also wrap up the configuration handlers so that they surface their data through it, along with the refresh tokens.

[tintoy]

There's a better way - I had to do something similar for KubeClient:

https://github.com/tintoy/dotnet-kube-client/tree/develop/src/KubeClient.Extensions.Configuration

[tintoy]

Specifically:

https://github.com/tintoy/dotnet-kube-client/blob/develop/src/KubeClient.Extensions.Configuration/ConfigMapConfigurationProvider.cs#L155

[tintoy]

Then:

https://github.com/tintoy/dotnet-kube-client/blob/develop/src/KubeClient.Extensions.Configuration/ConfigMapConfigurationProvider.cs#L191

[bjorkstromm]

I solved it by registering an own IOptionsMonitor<LoggerFilterOptions>

[david-driscoll]

LGTM

[david-driscoll]

We should probably look at a configuration integration. My thought is something like interface ILspConfiguration : IConfiguration and then populate that some defaults, like the logging state, but also wrap up the configuration handlers so that they surface their data through it, along with the refresh tokens.

[TylerLeonhardt]

why do we need to pass in the LogLevel for both the AddLanguageServer and SetMinimumLevel?

[bjorkstromm]

You don't need to. It's an option. One is global, the other one is just for LSP logging.

[TylerLeonhardt]

@mholo65 I gave this a go:

.AddSerilog()
.AddLanguageServer()
.SetMinimumLevel(LogLevel.Trace)

and the LSP side was only giving Information and Error but my file was giving me everything.