Skip to content

RGB values for colors are now represented using floats #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2019
Merged

RGB values for colors are now represented using floats #135

merged 1 commit into from
Apr 17, 2019

Conversation

theBadT
Copy link
Contributor

@theBadT theBadT commented Apr 4, 2019

Proposal for #134

@tintoy
Copy link
Collaborator

tintoy commented Apr 4, 2019

float or double?

@theBadT
Copy link
Contributor Author

theBadT commented Apr 5, 2019

float or double?

float

@david-driscoll
Copy link
Member

sounds good to me!

@david-driscoll david-driscoll merged commit 62cda45 into OmniSharp:master Apr 17, 2019
@bjorkstromm bjorkstromm mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@david-driscoll david-driscoll Awaiting requested review from david-driscoll

@tintoy tintoy Awaiting requested review from tintoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theBadT @tintoy @david-driscoll @bjorkstromm