Skip to content

Fixes FailureHandlingKind after LSP spec update #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

Fixes FailureHandlingKind after LSP spec update #129

merged 1 commit into from
Mar 19, 2019

Conversation

bjorkstromm
Copy link
Member

Tried out the betas with an updated LSP client and got this exception:

Unhandled Exception: Newtonsoft.Json.JsonSerializationException: Error converting value "textOnlyTransactional" to type 'System.Nullable`1[OmniSharp.Extensions.LanguageServer.Protocol.Models.FailureHandlingKind]'. Path 'params.capabilities.workspace.workspaceEdit.failureHandling', line 1, position 349. ---> System.ArgumentException: Requested value 'textOnlyTransactional' was not found.

@bjorkstromm bjorkstromm mentioned this pull request Mar 19, 2019
Merged
@david-driscoll david-driscoll merged commit 7d8567c into OmniSharp:master Mar 19, 2019
@NickAcPT NickAcPT mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-driscoll david-driscoll david-driscoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorkstromm @david-driscoll