Upgrade/latest lsp #126
Merged
Upgrade/latest lsp #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
reviewed
Mar 14, 2019
| @@ -10,6 +11,6 @@ public class DidChangeConfigurationParams : IRequest | |||
| /// <summary> | |||
| /// The actual changed settings | |||
| /// </summary> | |||
| public IDictionary<string, BooleanNumberString> Settings { get; set; } = new Dictionary<string, BooleanNumberString>(); | |||
| public JToken Settings { get; set; } | |||
There was a problem hiding this comment.
I feel like it changed at somepoint, I just never noticed it. Keeping a reference spec in sync is hard...
There was a problem hiding this comment.
I bet! You are doing an amazing job here working on this, and I very much appreciate your hard work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest lsp version, and also fixes a couple issues.
cc @mholo65 @tintoy @gep13