Skip to content

DiagnosticRelatedInformation Location should be an Location object #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drsoran opened this issue Sep 27, 2019 · 2 comments
Closed

DiagnosticRelatedInformation Location should be an Location object #175

drsoran opened this issue Sep 27, 2019 · 2 comments

Comments

@drsoran
Copy link
Contributor

drsoran commented Sep 27, 2019

Currently the DiagnosticRelatedInformation.Location property is a string. I think this is not correct in sense of Language Server Protocol. I think they expect Location to be an Location object with URI and Range.

I tried to pass a string but VS Code then displays related messages as:

undefined(undefined, undefined): message
@drsoran
Copy link
Contributor Author

drsoran commented Sep 28, 2019 •
edited
Loading

Possible solution prepared in PR #176

@david-driscoll
Copy link
Member

@drsoran I think you're correct. Thanks for the find!

@david-driscoll david-driscoll mentioned this issue Oct 2, 2019
Merged
david-driscoll pushed a commit that referenced this issue Oct 2, 2019
@drsoran @david-driscoll
Changes for #175 to return a Location object for diagnostic related i…
d67b8ec 
…nformation (#176)

* return a Location object instead of a string for the location of a diagnostic related information

* add test for related information with diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drsoran @david-driscoll