Support closing PR #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
commented
Aug 22, 2021
| if (bodyLower.includes("lgtm")) { | ||
| new Actor().mergeIfHasAccess(); | ||
| } else if (bodyLower.includes("@github-actions close")) { | ||
| new Actor().closeIfHasAccess(); |
There was a problem hiding this comment.
Should it require same access as merge? Should this also cover issues?
There was a problem hiding this comment.
I think it makes sense for closing PR/issues to instead only check on whether someone exists in the codeowners - given that the action can only have social downsides and not security downsides
Happy to ship this change myself tomorrow, and build it on this post merge 👍🏻
|
Looks solid to me, sneaking a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(On top of #23)
Fixes #22