Rebase origin onto master #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to remove its given file from PBXFileReference.
…eference after being modified by Xcode.
Adding COMPILER_FLAGS with = or space corrupts the project file and it can not be parsed by xcode or xcodebuild I tested how xcode behaves and it adds quotes around the COMPILER_FLAGS setting, but it doesn't add quotes to Weak from ATTRIBUTES. This is the reason this fix is applied only when opt.compilerFlags is present
Xcode handles this correctly and some tools might produce such projects.
… trailing comma In our testing, we've hit projects where trailing commas are not present with array entries.
By given array of files add a build phase which includes the given files. All files should be added to PBXBuildFileSection as well as to the PBXFileReferenceSection
Upon adding a build phase an unnecessary property is added, namely uuid
For given file paths add them to Build and File Reference sections if they're not already added and create a PBXGroup with given name, path and optional sourceTree. sourceTree defaults to <group> if no other specified
By given configuration objects, default configuration name and a comment add all configurations to PBXXCBuildConfigurationSection and add an XCConfigurationList
This way new knownRegions, TargetAttributes and targets can be added
Add a check - if a file exists in the PBXBuildFile and the PBXFileReference sections do not add it
Includes a bit of refactoring and extracting common logic between pbxGroupByName and pbxTargetByName into the more powerful function pbxItemByComment.
This enables greater customization when adding file to FileReference Section, like for example adding build output files (e.g. .app files or .appex files)
Includes creation of a PBXContainerItemProxy for each PBXTargetDependency and including the PBXTargetDependencies to the given target
e2l3n
referenced
this pull request
in NativeScript/nativescript-cli
Sep 2, 2015
|
👍 |
|
Ping @Fatme |
|
👍 |
KristianDD
pushed a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase origin (https://github.com/alunny/node-xcode) onto current master so that we have the latest changes from upstream.