Skip to content

feat: tests for playground samples used in docs #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 1, 2019
Merged

feat: tests for playground samples used in docs #63

merged 6 commits into from
Mar 1, 2019

Conversation

dtopuzov
Copy link
Contributor

@dtopuzov dtopuzov commented Feb 28, 2019 •
edited
Loading

New:

  • Tests for playground samples used in docs
  • Introduce new run_preview.py to run tests based on preview feature (it copy preview apps in sut folder once before tests)

Refactor:

  • Chrome: Add implicit wait of 60sec
  • Make run_adb_command and run_simctl_command public
  • Preview.run_url() now takes DeviceInfo object as param (instead of id and platform)
  • Escape playground url now happens in Preview.run_url() instead of Preview.get_url()

Fix:

  • Retry xcrun simctl install in case of failure (known issue of Xcode 10+)

@cla-bot cla-bot bot added the cla: yes label Feb 28, 2019
@dtopuzov dtopuzov merged commit ac950e5 into master Mar 1, 2019
@dtopuzov dtopuzov deleted the playground-docs branch March 1, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endarova endarova endarova approved these changes

@miroslavaivanova miroslavaivanova Awaiting requested review from miroslavaivanova

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtopuzov @endarova