Skip to content

chore: skip build with distribution provisioning on xcode10 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019
Merged

chore: skip build with distribution provisioning on xcode10 #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/cli/build/build_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import os
import unittest

from core.base_test.tns_test import TnsTest
from core.enums.os_type import OSType
from core.enums.platform_type import Platform
from core.log.log import Log
from core.settings import Settings
from core.settings.Settings import TEST_RUN_HOME
from core.utils.docker import Docker
from core.utils.file_utils import File, Folder
from core.utils.npm import Npm
from core.utils.docker import Docker
from core.utils.run import run
from core.utils.xcode import Xcode
from data.templates import Template
from products.nativescript.tns import Tns
from products.nativescript.tns_assert import TnsAssert
Expand Down Expand Up @@ -240,7 +243,11 @@ def test_190_build_ios_distribution_provisions(self):
assert Settings.IOS.DEVELOPMENT_TEAM in result.output

# Build with correct distribution provision
Tns.build_ios(self.app_name, provision=Settings.IOS.DISTRIBUTION_PROVISIONING, for_device=True, release=True)
if Xcode.get_version() < 11:
Log.info("Skip this check because we use new type of certificated that require Xcode 11.")
else:
Tns.build_ios(self.app_name, provision=Settings.IOS.DISTRIBUTION_PROVISIONING, for_device=True,
release=True)

# Verify that passing wrong provision shows user friendly error
result = Tns.build_ios(self.app_name, provision="fake", verify=False)
Expand Down