Skip to content

chore: assert error not in create output #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2019
Merged

chore: assert error not in create output #440

merged 3 commits into from
Nov 21, 2019

Conversation

dtopuzov
Copy link
Contributor

@dtopuzov dtopuzov commented Nov 18, 2019 •
edited
Loading

  • Assert "Error:" not in tns create output
  • Assert exit code
  • Add missing docs for params
  • Fix test_201_create_project_with_local_directory_template in cases tests are executed from folder different than project root

@dtopuzov
chore: assert error not in create output
f277882 
- Assert "Error:" not in tns create output
- Assert exit code
- Add missing docs for params
@cla-bot cla-bot bot added the cla: yes label Nov 18, 2019
@dtopuzov
chore: fix lint error
b0159f7 
- Fix lint error
- Fix `test_201_create_project_with_local_directory_template` in cases tests are executed from fodler different than project root
@dtopuzov
Merge branch 'master' into assert-no-errors-on-create
aac4a22
@dtopuzov
Copy link
Contributor Author

run core tests

1 similar comment
@dtopuzov
Copy link
Contributor Author

run core tests

@dtopuzov dtopuzov merged commit 2135193 into master Nov 21, 2019
@dtopuzov dtopuzov deleted the assert-no-errors-on-create branch December 9, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavaivanova miroslavaivanova miroslavaivanova approved these changes

@endarova endarova Awaiting requested review from endarova

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtopuzov @miroslavaivanova