fix: preview fallback path #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtopuzov
approved these changes
Nov 18, 2019
endarova
added a commit
that referenced
this pull request
Nov 20, 2019
* fix: docker on win (#434) * fix: cases when iOS version is 3 digits (#437) * fix: cases when Xcode version is 3 digits * chore: remove unused noinspection * fix: preview fallback path (#436) * set preview falback path according to os * fix win path * fix lint errors * fix: livesync failures (#438) * update master detail changes * update changes in hello world ng template * fix process name * chore: remove doctor templates (#439) - Remove doctor templates. - Add Tab Navigation Vue template. * chore: change the way we assert changes to improve tests stability * fix: flake8 error * fix: win path in package.json (#443) * fix path on win * fix paths on windows * update variable name * use fail_safe option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preview_folder_path is not passed as env. variable the fallback is only to /tns-dist but this is not working on windows.
Fix: set preview falback path according to the os
This will fix failing pr in nativescript-dev-webpack wneh they try to run preview tests on win