Skip to content

fix: update app bundle path #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2019
Merged

fix: update app bundle path #347

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
753b882
update path to aab
endarova Aug 28, 2019
a7ae180
uncomment fixed logs
endarova Aug 28, 2019
241cda6
fix linter errors
endarova Aug 28, 2019
c50a821
Merge branch 'master' into endarova/update-app_bundle_tests
endarova Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions tests/cli/build/android_app_bundle_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,11 @@ def test_200_build_android_app_bundle(self):
"""Build app with android app bundle option. Verify the output(app.aab) and use bundletool
to deploy on device"""
path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build", "outputs",
"bundle", "debug", "app.aab")
"bundle", "debug", "app-debug.aab")

Tns.build_android(self.app_path, aab=True, verify=False)
# There is an issue at the moment that the path is not shown in log.
# TODO: uncomment this when the issue is fixed
# assert "The build result is located at:" in result.output
# assert path_to_aab in result.output
result = Tns.build_android(self.app_path, aab=True, verify=False)
assert "The build result is located at:" in result.output
assert path_to_aab in result.output
assert File.exists(path_to_aab)

# Verify app can be deployed on emulator via bundletool
Expand All @@ -95,7 +93,7 @@ def test_205_build_android_app_bundle_env_snapshot(self):
# This test will not run on windows because env.snapshot option is not available on that OS

path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build",
"outputs", "bundle", "release", "app.aab")
"outputs", "bundle", "release", "app-release.aab")

# Configure app with snapshot optimisations
source = os.path.join('assets', 'abdoid-app-bundle', 'app.gradle')
Expand All @@ -107,12 +105,10 @@ def test_205_build_android_app_bundle_env_snapshot(self):
\nuseLibs: true,\nandroidNdkPath: \"$ANDROID_NDK_HOME\"""")

# env.snapshot is applicable only in release build
Tns.build_android(self.app_path, aab=True, release=True, snapshot=True,
uglify=True, verify=False)
# There is an issue at the moment that the path is not shown in log.
# TODO: uncomment this when the issue is fixed
# assert "The build result is located at:" in result.output
# assert path_to_aab in result.output
result = Tns.build_android(self.app_path, aab=True, release=True, snapshot=True,
uglify=True, verify=False)
assert "The build result is located at:" in result.output
assert path_to_aab in result.output
assert File.exists(path_to_aab)

# Verify app can be deployed on emulator via bundletool
Expand Down