Skip to content

fix: update logs - CLI changes #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2019
Merged

fix: update logs - CLI changes #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce0ec17
fix: update logs - CLI changes
Aug 26, 2019
990d990
Merge branch 'master' into Natalia-Hristova/update-tests-logs
Aug 27, 2019
5bd3280
Merge branch 'master' into Natalia-Hristova/update-tests-logs
Aug 27, 2019
90f417b
Merge branch 'master' into Natalia-Hristova/update-tests-logs
Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/runtimes/android/android_runtime_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ def test_317_check_native_crash_will_not_crash_when_discardUncaughtJsExceptions_
Device.click(self.emulator, "TAP", True)
if self.emulator.version == 6.0:
stack_trace_first_part = r"""### Stack Trace Start
JS: viewModel\.onTapfile:///app/main-view-model\.js:\d+:\d+
JS: at push\.\.\./node_modules/tns-core-modules/data/observable/observable\.js\.Observable\.notifyfile:///node_modules/tns-core-modules/data/observable/observable\.js:\d+:\d+
JS: at push\.\.\./node_modules/tns-core-modules/data/observable/observable\.js\.Observable\._emitfile:///node_modules/tns-core-modules/data/observable/observable\.js:\d+:\d+
JS: at ClickListenerImpl\.onClickfile:///node_modules/tns-core-modules/ui/button/button\.js:\d+:\d+
JS: viewModel\.onTap\(file:\/\/\/app\/main-view-model\.js:\d+:\d+\)
JS: at push\.\.\.\/node_modules\/tns-core-modules\/data\/observable\/observable\.js\.Observable\.notify\(file:\/\/\/node_modules\/tns-core-modules\/data\/observable\/observable\.js:\d+:\d+\)
JS: at push\.\.\.\/node_modules\/tns-core-modules\/data\/observable\/observable\.js\.Observable\._emit\(file:\/\/\/node_modules\/tns-core-modules\/data\/observable\/observable\.js:\d+:\d+\)
JS: at ClickListenerImpl\.onClick\(file:\/\/\/node_modules\/tns-core-modules\/ui\/button\/button\.js:\d+:\d+\)
JS: at com\.tns\.Runtime\.callJSMethodNative\(Native Method\)
JS: at com\.tns\.Runtime\.dispatchCallJSMethodNative\(Runtime\.java:\d+\)
JS: at com\.tns\.Runtime\.callJSMethodImpl\(Runtime\.java:\d+\)
Expand All @@ -193,10 +193,10 @@ def test_317_check_native_crash_will_not_crash_when_discardUncaughtJsExceptions_
JS: ### Stack Trace End""" # noqa: E501
else:
stack_trace_first_part = r"""### Stack Trace Start
JS: viewModel\.onTapfile:///app/main-view-model\.js:\d+:\d+
JS: at push\.\.\./node_modules/tns-core-modules/data/observable/observable\.js\.Observable\.notifyfile:///node_modules/tns-core-modules/data/observable/observable\.js:\d+:\d+
JS: at push\.\.\./node_modules/tns-core-modules/data/observable/observable\.js\.Observable\._emitfile:///node_modules/tns-core-modules/data/observable/observable\.js:\d+:\d+
JS: at ClickListenerImpl\.onClickfile:///node_modules/tns-core-modules/ui/button/button\.js:\d+:\d+
JS: viewModel\.onTap\(file:\/\/\/app\/main-view-model\.js:\d+:\d+\)
JS: at push\.\.\.\/node_modules\/tns-core-modules\/data\/observable\/observable\.js\.Observable\.notify\(file:\/\/\/node_modules\/tns-core-modules\/data\/observable\/observable\.js:\d+:\d+\)
JS: at push\.\.\.\/node_modules\/tns-core-modules\/data\/observable\/observable\.js\.Observable\._emit\(file:\/\/\/node_modules\/tns-core-modules\/data\/observable\/observable\.js:\d+:\d+\)
JS: at ClickListenerImpl\.onClick\(file:\/\/\/node_modules\/tns-core-modules\/ui\/button\/button\.js:\d+:\d+\)
JS: at com\.tns\.Runtime\.callJSMethodNative\(Native Method\)
JS: at com\.tns\.Runtime\.dispatchCallJSMethodNative\(Runtime\.java:\d+\)
JS: at com\.tns\.Runtime\.callJSMethodImpl\(Runtime\.java:\d+\)
Expand Down
4 changes: 2 additions & 2 deletions tests/runtimes/ios/ios_runtime_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ def test_386_check_native_crash_will_not_crash_when_discardUncaughtJsExceptions_

log = Tns.run_ios(app_name=APP_NAME, emulator=True)

strings = ['CONSOLE LOG file:///app/app.js:47:0 The folder “not-existing-path” doesn’t exist.',
'JS:\ncontentsOfDirectoryAtPathError(file:///app/main-view-model.js:6:0']
strings = ['CONSOLE LOG file:///app/app.js:47:0: The folder “not-existing-path” doesn’t exist.',
'JS:\ncontentsOfDirectoryAtPathError(file:///app/main-view-model.js:6:0)']

test_result = Wait.until(lambda: all(string in File.read(log.log_file) for string in strings), timeout=300,
period=5)
Expand Down