refactor: do not fail when kill process by pid

Do not fail if exception is raised when kill process by pid.
This pid might be already killed by something else.

Author: dtopuzov

core/utils/gradle.py

@@ -1,6 +1,4 @@
-# noinspection SpellCheckingInspection
 """
-# noinspection SpellCheckingInspection
 A wrapper around Gradle.
 """
 
@@ -12,7 +10,6 @@
 from core.utils.process import Run, Process
 
 
-# noinspection SpellCheckingInspection
 class Gradle(object):
     @staticmethod
     def kill():

core/utils/image_utils.py

@@ -68,7 +68,7 @@ def get_pixels_by_color(image_path, color, rdb_tolerance=25):
         Get count of pixels of specific color.
         :param image_path: Image path.
         :param color: Color as numpy array. Example: numpy.array([255, 217, 141])
-        :param rdb_tolerance If diff or rgb values is less then this count pixels will be counted as equal.
+        :param rdb_tolerance If diff of sums of rgb values is less then specified count pixels will be counted as equal.
         :return: Count of pixels.
         """
         img = ImageUtils.read_image(image_path=image_path)

core/utils/java.py

@@ -8,5 +8,9 @@
 class Java(object):
     @staticmethod
     def version():
+        """
+        Java version.
+        :rtype: float
+        """
         result = Run.command('java -version')
         return Version.get(result.output.split('"')[1])

core/utils/process.py

@@ -54,7 +54,7 @@ def command(cmd, cwd=Settings.TEST_RUN_HOME, wait=True, register_for_cleanup=Tru
             output = (str(out) + os.linesep + str(err)).rstrip()
             complete = True
             end = time.time()
-            duration = end - start;
+            duration = end - start
         else:
             process = Popen(cmd, shell=True, stdin=None, stdout=None, stderr=None, close_fds=True, cwd=cwd)
 
@@ -78,7 +78,9 @@ def command(cmd, cwd=Settings.TEST_RUN_HOME, wait=True, register_for_cleanup=Tru
 class Process(object):
     @staticmethod
     def is_running(proc_name):
-        """Check if process is running"""
+        """
+        Check if process is running.
+        """
         result = False
         for proc in psutil.process_iter():
             if proc_name in str(proc):
@@ -88,7 +90,9 @@ def is_running(proc_name):
 
     @staticmethod
     def is_running_by_commandline(commandline):
-        """Check if process with specified commandline is running"""
+        """
+        Check if process with specified commandline is running.
+        """
         proc = Process.get_proc_by_commandline(commandline=commandline)
         if proc is not None:
             return True
@@ -116,7 +120,8 @@ def get_proc_by_commandline(commandline):
 
     @staticmethod
     def wait_until_running(proc_name, timeout=60):
-        """Wait until process is running
+        """
+        Wait until process is running
         :param proc_name: Process name.
         :param timeout: Timeout in seconds.
         :return: True if running, false if not running.
@@ -177,8 +182,11 @@ def kill_by_commandline(cmdline):
 
     @staticmethod
     def kill_pid(pid):
-        p = psutil.Process(pid)
-        p.terminate()
+        try:
+            p = psutil.Process(pid)
+            p.terminate()
+        except Exception:
+            pass
 
     @staticmethod
     def kill_by_handle(file_path):

core/utils/wait.py

@@ -4,6 +4,11 @@
 class Wait(object):
     @staticmethod
     def until(condition, timeout=60, period=1, *args, **kwargs):
+        """
+        Wait until condition is satisfied.
+        :rtype: bool
+        :returns: True if condition is satisfied before timeout, otherwise False.
+        """
         end_time = time.time() + timeout
         while time.time() < end_time:
             if condition(*args, **kwargs):

core/utils/xcode.py

@@ -19,6 +19,5 @@ def get_version():
         Get Xcode version
         :return: Version as int.
         """
-        # noinspection SpellCheckingInspection
         result = Run.command(cmd='xcodebuild -version').output.splitlines()[0].replace(' ', '').replace('Xcode', '')
         return Version.get(result)