refactor: BaseTest is now TnsTest

Do not use BaseTest, in future we may have multiple base tests.
For example base test for CLI tests, base tests for schematics tests and so on.

Author: dtopuzov

core/base_test/base_test.py renamed to core/base_test/tns_test.py

@@ -14,7 +14,7 @@
 from products.nativescript.tns import Tns
 
 
-class BaseTest(unittest.TestCase):
+class TnsTest(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
         # Get class name and log
@@ -24,7 +24,7 @@ def setUpClass(cls):
         # Kill processes
         Tns.kill()
         Gradle.kill()
-        BaseTest.kill_emulators()
+        TnsTest.kill_emulators()
 
         # Ensure log folders are create
         Folder.create(Settings.TEST_OUT_HOME)
@@ -65,7 +65,7 @@ def tearDownClass(cls):
         Logic executed after all core_tests in class.
         """
         Tns.kill()
-        BaseTest.kill_emulators()
+        TnsTest.kill_emulators()
         for process in TestContext.STARTED_PROCESSES:
             Log.info("Kill Process: " + os.linesep + process.commandline)
             Process.kill_pid(process.pid)

core_tests/core/device_tests.py

@@ -1,30 +1,30 @@
 import os
 
-from core.base_test.base_test import BaseTest
+from core.base_test.tns_test import TnsTest
 from core.enums.device_type import DeviceType
 from core.settings import Settings
 from core.utils.device.device_manager import DeviceManager
 from core.utils.device.emulator_info import EmulatorInfo
 
 
 # noinspection PyMethodMayBeStatic
-class DeviceTests(BaseTest):
+class DeviceTests(TnsTest):
 
     @classmethod
     def setUpClass(cls):
-        BaseTest.setUpClass()
+        TnsTest.setUpClass()
 
     def setUp(self):
-        BaseTest.setUp(self)
+        TnsTest.setUp(self)
 
     def tearDown(self):
         DeviceManager.Emulator.stop()
         DeviceManager.Simulator.stop()
-        BaseTest.tearDown(self)
+        TnsTest.tearDown(self)
 
     @classmethod
     def tearDownClass(cls):
-        BaseTest.tearDownClass()
+        TnsTest.tearDownClass()
 
     def test_01_emulator(self):
         # Verify emulator is started properly

core_tests/products/tns_tests.py

@@ -2,7 +2,7 @@
 
 from nose.tools import timed
 
-from core.base_test.base_test import BaseTest
+from core.base_test.tns_test import TnsTest
 from core.enums.os_type import OSType
 from core.settings import Settings
 from core.utils.device.device_manager import DeviceManager
@@ -11,30 +11,30 @@
 from products.nativescript.tns import Tns
 
 
-class TnsTests(BaseTest):
+class TnsTests(TnsTest):
     app_name = Settings.AppName.DEFAULT
     app_folder = os.path.join(Settings.TEST_RUN_HOME, app_name)
     emu = None
     sim = None
 
     @classmethod
     def setUpClass(cls):
-        BaseTest.setUpClass()
+        TnsTest.setUpClass()
         Tns.create(app_name=cls.app_name)
         cls.emu = DeviceManager.Emulator.ensure_available(Settings.Emulators.DEFAULT)
         if Settings.HOST_OS is OSType.OSX:
             cls.sim = DeviceManager.Simulator.ensure_available(Settings.Simulators.DEFAULT)
 
     def setUp(self):
-        BaseTest.setUp(self)
+        TnsTest.setUp(self)
 
     def tearDown(self):
         Tns.kill()
-        BaseTest.tearDown(self)
+        TnsTest.tearDown(self)
 
     @classmethod
     def tearDownClass(cls):
-        BaseTest.tearDownClass()
+        TnsTest.tearDownClass()
 
     @timed(300)
     def test_001_tns_run_android(self):

products/nativescript/app.py

@@ -32,6 +32,18 @@ def is_dependency(app_name, dependency):
                 return True
         return False
 
+    @staticmethod
+    def install_dependency(app_name, dependency, version='latest'):
+        app_path = os.path.join(Settings.TEST_RUN_HOME, app_name)
+        Npm.uninstall(package=dependency, option='--save', folder=app_path)
+        Npm.install(package='{0}@{1}'.format(dependency, version), option='--save', folder=app_path)
+
+    @staticmethod
+    def install_dev_dependency(app_name, dependency, version='latest'):
+        app_path = os.path.join(Settings.TEST_RUN_HOME, app_name)
+        Npm.uninstall(package=dependency, option='--save-dev', folder=app_path)
+        Npm.install(package='{0}@{1}'.format(dependency, version), option='--save-dev', folder=app_path)
+
     @staticmethod
     def update(app_name, modules=True, angular=True, typescript=True, web_pack=True, ns_plugins=False):
         app_path = os.path.join(Settings.TEST_RUN_HOME, app_name)

products/nativescript/tns.py

@@ -16,7 +16,7 @@ class Tns(object):
     @staticmethod
     def exec_command(command, cwd=Settings.TEST_RUN_HOME, platform=Platform.NONE, path=None, device=None, release=False,
                      for_device=False, provision=Settings.IOS.DEV_PROVISION, bundle=False, aot=False, uglify=False,
-                     snapshot=False, log_trace=False, justlaunch=False, wait=True):
+                     snapshot=False, log_trace=False, justlaunch=False, wait=True, timeout=600):
         """
         Execute tns command.
         :param command: Tns command.
@@ -34,6 +34,7 @@ def exec_command(command, cwd=Settings.TEST_RUN_HOME, platform=Platform.NONE, pa
         :param log_trace: If true pass `--log trace` to command.
         :param justlaunch: If true pass `--justlaunch` to command.
         :param wait: If true it will wait until command is complete.
+        :param timeout: Timeout for CLI command (respected only if wait=True).
         :return: ProcessInfo object.
         :rtype: core.utils.process_info.ProcessInfo
         """
@@ -68,7 +69,7 @@ def exec_command(command, cwd=Settings.TEST_RUN_HOME, platform=Platform.NONE, pa
             cmd += ' --justlaunch'
         if log_trace:
             cmd += ' --log trace'
-        return Run.command(cmd=cmd, cwd=cwd, wait=wait, log_level=logging.INFO)
+        return Run.command(cmd=cmd, cwd=cwd, wait=wait, log_level=logging.INFO, timeout=timeout)
 
     @staticmethod
     def create(app_name=Settings.AppName.DEFAULT, template=None, path=None, app_id=None,
@@ -127,10 +128,19 @@ def create(app_name=Settings.AppName.DEFAULT, template=None, path=None, app_id=N
 
         return result
 
+    @staticmethod
+    def platform_remove(app_name=Settings.AppName.DEFAULT, platform=Platform.NONE, verify=True,
+                        log_trace=False):
+        command = 'platform remove ' + str(platform) + ' --path ' + app_name
+        result = Tns.exec_command(command=command, log_trace=log_trace)
+        if verify:
+            # TODO: Implement it!
+            pass
+        return result
+
     @staticmethod
     def platform_add(app_name=Settings.AppName.DEFAULT, platform=Platform.NONE, framework_path=None, version=None,
-                     verify=True,
-                     log_trace=False):
+                     verify=True, log_trace=False):
         platform_add_string = str(platform)
         if version is not None:
             platform_add_string = platform_add_string + '@' + version
@@ -257,13 +267,25 @@ def debug(app_name, platform, device=None, release=False, provision=Settings.IOS
     def doctor(app_name=None):
         """
         Execute `tns doctor`
-        :param app_name: App where command will be executed (by default None -> doctor will be executed outside app).
+        :param app_name: App where command will be executed (by default None -> common will be executed outside app).
         :return: Result of `tns doctor` command.
         """
         cwd = Settings.TEST_RUN_HOME
         if app_name is not None:
             cwd = os.path.join(cwd, app_name)
-        return Tns.exec_command(command='doctor', cwd=cwd)
+        return Tns.exec_command(command='doctor', cwd=cwd, timeout=60)
+
+    @staticmethod
+    def info(app_name=None):
+        """
+        Execute `tns info`
+        :param app_name: App where command will be executed (by default None -> common will be executed outside app).
+        :return: Result of `tns info` command.
+        """
+        cwd = Settings.TEST_RUN_HOME
+        if app_name is not None:
+            cwd = os.path.join(cwd, app_name)
+        return Tns.exec_command(command='info', cwd=cwd, timeout=60)
 
     @staticmethod
     def version():

run_common.py

@@ -47,7 +47,6 @@ def __get_templates():
             raise IOError("Failed to clone and pack template: " + app.repo)
 
 
-# noinspection SpellCheckingInspection
 def __get_packages():
     """
     Get NativeScript CLI and runtimes in TEST_SUT_HOME.

run_ns.py

@@ -8,7 +8,6 @@
 if __name__ == '__main__':
     run_common.prepare()
     Log.info("Running core_tests...")
-    # noinspection SpellCheckingInspection
     arguments = ['nosetests', '-v', '-s', '--nologcapture', '--with-doctest', '--with-xunit', '--with-flaky']
     for i in sys.argv:
         arguments.append(str(i))

run_schematics.py

@@ -8,7 +8,6 @@
 if __name__ == '__main__':
     run_common.prepare(shared=True)
     Log.info("Running core_tests...")
-    # noinspection SpellCheckingInspection
     arguments = ['nosetests', '-v', '-s', '--nologcapture', '--with-doctest', '--with-xunit', '--with-flaky']
     for i in sys.argv:
         arguments.append(str(i))

tests/__init__.py

@@ -0,0 +1,83 @@
+import os
+
+from core.base_test.tns_test import TnsTest
+from core.enums.os_type import OSType
+from core.enums.platform_type import Platform
+from core.settings import Settings
+from data.templates import Template
+from products.nativescript.app import App
+from products.nativescript.tns import Tns
+
+RETRY_COUNT = 3
+APP_NAME = Settings.AppName.DEFAULT
+
+
+# noinspection PyMethodMayBeStatic
+class DoctorFunctionalTests(TnsTest):
+    ANDROID_HOME = os.environ.get('ANDROID_HOME')
+    JAVA_HOME = os.environ.get('JAVA_HOME')
+
+    @classmethod
+    def setUpClass(cls):
+        TnsTest.setUpClass()
+
+    def setUp(self):
+        TnsTest.setUp(self)
+        os.environ['ANDROID_HOME'] = self.ANDROID_HOME
+        os.environ['JAVA_HOME'] = self.JAVA_HOME
+
+    @classmethod
+    def tearDownClass(cls):
+        TnsTest.tearDownClass()
+
+    def test_001_doctor(self):
+        result = Tns.doctor()
+        assert result.exit_code == 0, 'Doctor exit with non zero exit code.'
+
+        output = result.output
+        assert 'No issues were detected.' in output
+        assert 'Your ANDROID_HOME environment variable is set and points to correct directory.' in output
+        assert 'Your adb from the Android SDK is correctly installed.' in output
+        assert 'The Android SDK is installed.' in output
+        assert 'A compatible Android SDK for compilation is found.' in output
+        assert 'Javac is installed and is configured properly.' in output
+        assert 'The Java Development Kit (JDK) is installed and is configured properly.' in output
+        if Settings.HOST_OS != OSType.OSX:
+            assert 'Local builds for iOS can be executed only on a macOS system. To build for iOS on a different ' \
+                   'operating system, you can use the NativeScript cloud infrastructure.' in output
+        else:
+            assert 'Xcode is installed and is configured properly.' in output
+            assert 'xcodeproj is installed and is configured properly.' in output
+            assert 'CocoaPods are installed.' in output
+            assert 'CocoaPods update is not required.' in output
+            assert 'CocoaPods are configured properly.' in output
+            assert 'Your current CocoaPods version is newer than 1.0.0' in output
+            assert 'Python installed and configured correctly.' in output
+            assert "The Python 'six' package is found." in output
+
+    def test_200_doctor_show_warning_when_new_components_are_available(self):
+        Tns.create(app_name=APP_NAME, template=Template.HELLO_WORLD_JS.local_package, update=False)
+        Tns.platform_add_android(app_name=APP_NAME, version='4')
+        App.install_dependency(app_name=APP_NAME, dependency='tns-core-modules', version='4')
+
+        doctor_result = Tns.doctor(app_name=APP_NAME)
+        doctor_output = doctor_result.output
+
+        info_result = Tns.info(app_name=APP_NAME)
+        info_output = info_result.output
+
+        for output in (doctor_output, info_output):
+            assert 'Update available for component tns-core-modules' in output
+            assert 'Update available for component tns-android' in output
+
+    def test_400_doctor_should_detect_wrong_path_to_android_sdk(self):
+        os.environ['ANDROID_HOME'] = 'WRONG_PATH'
+        output = Tns.doctor().output
+        assert 'There seem to be issues with your configuration.' in output
+        assert 'The ANDROID_HOME environment variable is not set or it points to a non-existent directory' in output
+
+    def test_401_doctor_should_detect_wrong_path_to_java(self):
+        os.environ['JAVA_HOME'] = 'WRONG_PATH'
+        output = Tns.doctor().output
+        assert "Error executing command 'javac'." in output
+        assert 'The Java Development Kit (JDK) is not installed or is not configured properly.' in output

tests/cli/build/common/doctor_tests.py

@@ -1,7 +1,7 @@
 import os
 import unittest
 
-from core.base_test.base_test import BaseTest
+from core.base_test.tns_test import TnsTest
 from core.enums.os_type import OSType
 from core.enums.platform_type import Platform
 from core.settings import Settings
@@ -15,7 +15,7 @@
 from products.nativescript.tns import Tns
 
 
-class TnsRunJSTests(BaseTest):
+class TnsRunJSTests(TnsTest):
     app_name = Settings.AppName.DEFAULT
     source_project_dir = os.path.join(Settings.TEST_RUN_HOME, app_name)
     target_project_dir = os.path.join(Settings.TEST_RUN_HOME, 'data', 'temp', app_name)
@@ -24,7 +24,7 @@ class TnsRunJSTests(BaseTest):
 
     @classmethod
     def setUpClass(cls):
-        BaseTest.setUpClass()
+        TnsTest.setUpClass()
 
         # Boot emulator and simulator
         cls.emu = DeviceManager.Emulator.ensure_available(Settings.Emulators.DEFAULT)
@@ -42,7 +42,7 @@ def setUpClass(cls):
         Folder.copy(source=cls.source_project_dir, target=cls.target_project_dir)
 
     def setUp(self):
-        BaseTest.setUp(self)
+        TnsTest.setUp(self)
         # "src" folder of TestApp will be restored before each test.
         # This will ensure failures in one test do not cause common failures.
         source_src = os.path.join(self.target_project_dir, 'app')
@@ -52,7 +52,7 @@ def setUp(self):
 
     @classmethod
     def tearDownClass(cls):
-        BaseTest.tearDownClass()
+        TnsTest.tearDownClass()
 
 
 class RunAndroidJSTests(TnsRunJSTests):