Manually import newly created components in the right NgModules #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were delegating the task of declaring new components inside an NgModule to the external
component
schematic. However, this causes two problems:app.module.web.ts
), the external schematic won't find an NgModule to declare the new component in. That's because the external schematic looks only for files ending with.module.ts
.app.module.tns.ts
).With these changes, the external component schematic is always called with
skipImport: true
and the new component is manually declared inside an appropriate NgModule (web, mobile or both).The PR also adds a simple VSCode launch configuration for debugging unit tests.
fixes #78, #54