feat: generate stylesheets when migrating components and modules #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use --no-style to skip generation of the css / scss files
sis0k0
changed the title
sis0k0
reviewed
Oct 10, 2018
| } | ||
|
|
||
| if (ts.isArrayLiteralExpression(node) && node.elements.length > 0) { | ||
| const stylePath = (node.elements[0] as ts.StringLiteral).text; |
There was a problem hiding this comment.
What if there are multiple stylesheets for the same component?
There was a problem hiding this comment.
I thought about that, but 99.9% of the cases would use just a single stylesheet. And in the cases that there are more it would probably be better to handle it manually
sis0k0
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
--no-styleto skip the generation of [css | scss] files