-
-
Notifications
You must be signed in to change notification settings - Fork 72
feat(android): add support for mediaType option for android devices #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
1 similar comment
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuhcc
Thank you for your PR. However, the demo app, currently crashes with Cannot read property 'Image' of undefined
error. It seem like the ImagePickerMediaType enumeration is not recognised in the imagepicker.android.ts file. Can you check?
Hi @tgpetrov I just tried both |
I also merged latest commits from master into this branch. Unfortunately
|
@xuhcc It seems like the issue I was hitting was related to a braking change in NativeScript CLI 6.0, so I had to include the ImagePickerMediaType in a ts file (and not only d.ts as until now). When I applied your changes, the checks were successful. Thank you for your contribution! |
OK, thank you! |
PR Checklist
What is the current behavior?
mediaType
option only works on iOS.What is the new behavior?
mediaType
option supported on Android too.Implements #175.