Skip to content

fix(ios): no blurred images in image picker #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2018

Conversation

JakubPawlak
Copy link
Contributor

@JakubPawlak JakubPawlak commented Sep 7, 2018

Fix for displaying blurred images in image picker when the root view of the app is any layout nesting TabView.
Branch on which there is a reproduced bad behaviour is here:
https://github.com/JakubPawlak/nativescript-imagepicker/tree/blur

PR Checklist

What is the current behavior?

In some specific cases, image picker is showing blurred images.
#195

What is the new behavior?

No blurred images.

Fixes #195

No migration steps.

fix for displaying blurred images in image picker when the root view of the app is any layout nesting TabView

related to NativeScript#195
@ghost ghost added the new PR label Sep 7, 2018
@ghost ghost assigned lini Sep 11, 2018
@lini
Copy link
Contributor

lini commented Sep 11, 2018

The CI build for this PR failed because the changed code references tns-core-modules version 4+ and the plugin's package.json is still configured to use version 3:

"tns-core-modules": "^3.1.0",
"tns-platform-declarations": "^3.1.0",

You should either update the references in package.json or make the code work without them. The error at the moment is:

$ tsc
imagepicker.ios.ts:31:46 - error TS2339: Property 'viewController' does not exist on type 'View'.

31         return this.hostView ? this.hostView.viewController : UIApplication.sharedApplication.keyWindow.rootViewController;
                                                ~~~~~~~~~~~~~~

@JakubPawlak
Copy link
Contributor Author

Can I make a test CI build myself?

@lini
Copy link
Contributor

lini commented Sep 12, 2018

The CI is public and you can view the results by going directly to https://travis-ci.org/NativeScript/nativescript-imagepicker/pull_requests
Each time you make changes to the PR, a new build will be triggered but it might take some time for it to finish, since it runs on a shared environment along with other open-source projects.

Updated tns dependencies versions to 4.0.0
@JakubPawlak
Copy link
Contributor Author

Ok, so I fixed package.json versions but now there are errors during UI tests... Any hints how to fix them?

@zbranzov
Copy link
Contributor

@JakubPawlak Unfortunately, our tests use env variables that are not exposed by PR made from forks https://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions. I will test your branch and merge it manually.

@zbranzov
Copy link
Contributor

@zbranzov zbranzov merged commit bd261cd into NativeScript:master Sep 12, 2018
@ghost ghost removed the new PR label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants