Skip to content

chore: allow only local files for picking #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2018

Conversation

tgpetrov
Copy link
Contributor

PR Checklist

What is the current behavior?

Currently user is allowed to pick an image from external storage like SDCard, Google Drive, etc. but when an image is selected, its filename is not correctly resolved by the plugin and the image is not displayed in the demo.

What is the new behavior?

The user is allowed to pick only images from local storage, so when any image is selected it can be correctly visualised by the application.

Related with #189.

@tgpetrov tgpetrov requested a review from nsplugins July 10, 2018 11:08
@ghost ghost assigned tgpetrov Jul 10, 2018
@ghost ghost added the new PR label Jul 10, 2018
@tgpetrov tgpetrov force-pushed the tgpetrov/android-pick-local branch from ba850bf to b0c14f7 Compare July 13, 2018 12:27
@ghost ghost assigned DimitarTodorov Jul 16, 2018
@DimitarTodorov DimitarTodorov merged commit 86a93a7 into master Jul 17, 2018
@ghost ghost removed the ready for test label Jul 17, 2018
@lini lini deleted the tgpetrov/android-pick-local branch September 11, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants